c++ - Is this bad code? -


i've been using code style while now, make class has "id" in front of it, place in header, make .cpp file , put class called "idclassnamelocal". make pure virtual functions in abstract header class, make normal virtual functions in .cpp class , have inherit abstract header class.

is bad code design , coding efficiently?

  • i put id(identification) in front of class name prevent redefinition , cleanness.

example:

// player.h // //////////////////////////////////////////////////////////////// class idplayer { public:     virtual ~idplayer(void) {} // destructor      virtual void playerdata(void) = 0;     virtual void controls(void) = 0; }; extern idplayer* idplayer;  // player.cpp // ////////////////////////////////////////////////////////////// class idplayerlocal : public idplayer { public:     idplayer(void) {} // constructor      virtual void playerdata(void);     virtual void controls(void); }; idplayerlocal idplayerlocal; idplayer* idplayer = &idplayerlocal; // class function definitions void idplayerlocal::playerdata(void) {     player.x = 400;     player.y = 500;      player.w = 20;     player.h = 20;      player.velocityx = (float)0.31;     player.velocityy = (float)0.31; }  void idplayerlocal::controls(void) {     if(::maingame) {         if(key_down(0x41)) { //             player.x = player.x - player.velocityx;             if(player.x <= 0)                 player.x = 0;         }         if(key_down(0x44)) { // d             player.x = player.x + player.velocityx;             if(player.x+player.w >= 650)                 player.x = 650 - player.w;         }         if(key_down(0x57)) { // w             player.y = player.y - player.velocityy;             if(player.y <= 0)                 player.y = 0;         }         if(key_down(0x53)) { // s             player.y = player.y + player.velocityy;             if(player.y+player.h >= 570)                 player.y = 570 - player.h;         }         if(key_down(vk_space)) {          }     } }   // core.cpp // ////////////////////////////////////////////////////////////////  // ... // intialized data // idplayer->playerdata();  while(true) {     // ...     // loop data //     idplayer->controls();     // ... } // ...

as long using same style throughout code no style bad unless unreadable. able go through code without trouble style. consistent throughout project.


Comments

Post a Comment

Popular posts from this blog

ios - iPhone/iPad different view orientations in different views , and apple approval process -

i force app's home screen portrait , other views landscape. apple rejects app if this? if not , how force first screen launch in portrait mode? , force other screens launch in landscape. this not duplicate question search every possible answer in website. i force app's home screen portrait , other views landscape. apple rejects app if this? no apple not reject app this. have lot of apps doesn't support orientation. forcing on 1 screen won't cause app reject. if not , how force first screen launch in portrait mode? , force other screens launch in landscape. can on write : -(nsuinteger)supportedinterfaceorientations; function.
Read more

java Extracting Zip file -

i'm looking way extract zip file. far have tried java.util.zip , org.apache.commons.compress, both gave corrupted output. basically, input zip file contain 1 single .doc file. java.util.zip: output corrupted. org.apache.commons.compress: output blank file, 2 mb size. so far commercial software winrar work perfectly. there java library make use of this? this method using java.util library: public void extractzipnative(file filezip) { zipinputstream zis; stringbuilder sb; try { zis = new zipinputstream(new fileinputstream(filezip)); zipentry ze = zis.getnextentry(); byte[] buffer = new byte[(int) ze.getsize()]; fileoutputstream fos = new fileoutputstream(this.tempfolderpath+ze.getname()); int len; while ((len=zis.read(buffer))>0) { fos.write(buffer); } fos.flush(); fos.close(); } catch (filenotfoundexception e) { // todo auto-generated catch block ...
Read more

C# WinForm - loading screen -

i ask how make loading screen (just picture or something) appears while program being loaded, , disappears when program has finished loading. in fancier versions, have seen process bar (%) displayed. how can have that, , how calculate % show on it? i know there form_load() event, not see form_loaded() event, or % property / attribute anywhere. all need create 1 form splash screen , show before main start showing landing page , close splash once landing page loaded. class splashform { //delegate cross thread call close private delegate void closedelegate(); //the type of form displayed splash screen. private static splashform splashform; static public void showsplashscreen() { // make sure launched once. if (splashform != null) return; thread thread = new thread(new threadstart(splashform.showform)); thread.isbackground = true; thread.setapartmentstate(apartmentstate.sta); thread....
Read more